Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trigger system testing on PRs that don't need it #2059

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ni-jfitzger
Copy link
Collaborator

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Right now we pretty much always run system tests on our PRs, even if we're just changing the README.md.

This changes our triggering so we only run system tests in the following cases:

  • A workflow or the action it uses is changed
  • We change a generated module or its source
  • We change the tools folder (where we keep the coverage rc files)

I'm not changing the trigger for merges at this time.

  • A special setting would be needed to not mess up the reported coverage in cases where we don't run the tests
    • I'm sure I could look it up, but there could be some churn
  • I feel more secure knowing we pretty much always run tests on the latest commit, in case I overlooked something important in our triggering requirements

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

None

@ni-jfitzger ni-jfitzger marked this pull request as ready for review May 1, 2024 15:40
@ni-jfitzger ni-jfitzger changed the title [DO NOT MERGE] Do not trigger system testing on PRs that don't need it Do not trigger system testing on PRs that don't need it May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant