NI-DMM: Make getting the last calibration temp and datetime consistent with other drivers.

[shilohbeeler-NI]

• This contribution adheres to CONTRIBUTING.md.

• I've updated CHANGELOG.md if applicable.

• I've added tests applicable for this pull request

What does this Pull Request accomplish?

Adds external and self calibration variations of get last cal temp and get last cal date and time, in order to be consistent with other drivers with similar methods. Removes the previously existing get last cal date time method since it was an added function rather than part of base metadata, and is now redundant with the newly added methods.

List issues fixed by this Pull Request below, if any.

• Fix nidmm.Session.get_cal_date_and_time and get_last_cal_temp is different from other nimi-python drivers #1462

What testing has been done?

Branch has successfully built and passed all system tests on a local testing machine.

[nimi-bot]

Can one of the admins verify this patch?

[codecov]

Codecov Report

Merging #1498 into master will increase coverage by 2.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1498      +/-   ##
==========================================
+ Coverage   91.65%   93.88%   +2.22%     
==========================================
  Files          20       32      +12     
  Lines        3451     6848    +3397     
==========================================
+ Hits         3163     6429    +3266     
- Misses        288      419     +131     

Flag	Coverage Δ
#codegenunittests	88.27% <ø> (ø)
#nidcpowersystemtests	98.58% <ø> (?)
#nidigitalsystemtests	96.91% <ø> (?)
#nidmmsystemtests	95.48% <ø> (?)
#nifakeunittests	96.32% <ø> (ø)
#nifgensystemtests	96.91% <ø> (?)
#nimodinstsystemtests	87.23% <ø> (?)
#nimodinstunittests	95.37% <ø> (ø)
#niscopesystemtests	91.31% <ø> (?)
#nisesystemtests	100.00% <ø> (?)
#niswitchsystemtests	98.11% <ø> (?)
#nitclksystemtests	100.00% <ø> (?)
#nitclkunittests	95.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
generated/niswitch/niswitch/_library.py	98.11% <0.00%> (ø)
generated/niscope/niscope/waveform_info.py	57.35% <0.00%> (ø)
generated/nise/nise/_library.py	100.00% <0.00%> (ø)
generated/niscope/niscope/_library.py	95.32% <0.00%> (ø)
generated/nitclk/nitclk/_library.py	100.00% <0.00%> (ø)
generated/nifgen/nifgen/_library.py	96.91% <0.00%> (ø)
generated/nidmm/nidmm/_library.py	95.48% <0.00%> (ø)
generated/niscope/niscope/measurement_stats.py	100.00% <0.00%> (ø)
...digital/nidigital/history_ram_cycle_information.py	100.00% <0.00%> (ø)
generated/nidcpower/nidcpower/_library.py	98.58% <0.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df49436...c759242. Read the comment docs.

[sbethur]

ok to test

[shilohbeeler-NI]

I'll leave the branch on my fork of the repo so that any code I wrote doesn't just disappear. If I'd had a week more, my plan was to look into making the cal temp/date and time stuff into single-sourced templates, but I don't think that's feasible in the span of approximately a day since I've never looked into that part of the codebase at all before.

[marcoskirsch]

I think it's worth adding these methods, and we worry about obsoleting the old inconsistent ones separately. Do you agree @sbethur ?

[sbethur]

I think it's worth adding these methods, and we worry about obsoleting the old inconsistent ones separately. Do you agree @sbethur ?

I agree. But I'd want to add it without duplicating the mako templates between niscope and nidmm.