Fix table scroll tests on WebKit #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msmithNI, will you buddy this PR for me? |
msmithNI
approved these changes
Mar 27, 2024
rajsite
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Resolves #1942
👩💻 Implementation
WebKit doesn't appear to fire the
scrollevent when a scroll done by settingscrollTopon an element. Therefore, I've updated the page object to scroll using thescroll()function, which does cause the event to be fired. As a result, the table's virtualizer correctly detects the change and the tests pass.🧪 Testing
Ran all the table tests in webkit locally and on the pipeline to verify they pass.
✅ Checklist