Table keyboard navigation HLD #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmithNI
requested review from
rajsite,
jattasNI,
atmgrifter00 and
mollykreis
as code owners
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
fredvisser
reviewed
Mar 27, 2024
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
atmgrifter00
approved these changes
Mar 27, 2024
Co-authored-by: Fred Visser <[email protected]>
mollykreis
reviewed
Mar 27, 2024
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Show resolved
Hide resolved
fredvisser
approved these changes
Mar 27, 2024
jattasNI
reviewed
Mar 27, 2024
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
msmithNI
commented
Mar 29, 2024
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Show resolved
Hide resolved
jattasNI
approved these changes
Mar 29, 2024
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Show resolved
Hide resolved
mollykreis
reviewed
Apr 1, 2024
packages/nimble-components/src/table/specs/table-keyboard-navigation-hld.md
Show resolved
Hide resolved
rajsite
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
HLD for #1137
👩💻 Implementation
Started with the HLD document from #1506 , and updated it to reflect our decision to standardize on the ARIA treegrid role (moved the info about the grid role/ previous IxD design to the Alternatives section), and added an explicit section with the specific interactions as they'll apply to the Nimble table.
Note: Currently there isn't a prototype that fully reflects the interactions detailed in this document, but that's in-progress.