Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Blazor wrapper for number-text column #1535

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Conversation

mollykreis
Copy link
Contributor

Pull Request

🀨 Rationale

This adds Blazor support for the number-text column, which is part of #1011

πŸ‘©β€πŸ’» Implementation

  • Add Blazor component and tests for the number-text column following the pattern we've used for other table columns
  • Add number-text column to the example Blazor app

πŸ§ͺ Testing

  • Added new unit tests
  • Manually verified that the example app behaves as expected

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis
Copy link
Contributor Author

@atmgrifter00, can you buddy this for me?

@mollykreis mollykreis marked this pull request as ready for review September 14, 2023 20:18
Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look at the Blazor changes, just approving the all-components.ts change

@rajsite rajsite enabled auto-merge (squash) September 15, 2023 19:40
@rajsite rajsite merged commit 2a98738 into main Sep 15, 2023
@rajsite rajsite deleted the number-column-blazor branch September 15, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants