Add localized labels to remaining table sub-elements #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollykreis
commented
Sep 12, 2023
packages/nimble-components/src/label-provider/table/label-token-defaults.ts
Outdated
Show resolved
Hide resolved
|
@msmithNI, could you buddy this PR for me? |
msmithNI
approved these changes
Sep 12, 2023
packages/nimble-components/src/label-provider/table/label-token-defaults.ts
Outdated
Show resolved
Hide resolved
mollykreis
commented
Sep 18, 2023
|
@atmgrifter00, do you mind doing a second buddy review on these changes? Specifically, can you provide a review on the changes to the way that we are optionally adding an additional "column" for the row selection checkbox and group all button? |
atmgrifter00
approved these changes
Sep 18, 2023
rajsite
approved these changes
Sep 19, 2023
jattasNI
approved these changes
Sep 19, 2023
This was referenced Sep 20, 2023
mollykreis
added a commit
that referenced
this pull request
Sep 22, 2023
# Pull Request ## 🤨 Rationale The new labels added in #1519 need to be exposed in Blazor ## 👩💻 Implementation Followed existing pattern to expose and test new labels ## 🧪 Testing Ran unit tests ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed.
mollykreis
added a commit
that referenced
this pull request
Sep 22, 2023
# Pull Request ## 🤨 Rationale The new labels added in #1519 need to be exposed in Angular ## 👩💻 Implementation Followed existing pattern to expose and test new labels ## 🧪 Testing Ran unit tests ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed.
rajsite
added a commit
that referenced
this pull request
Sep 25, 2023
…ch other (#1555) # Pull Request ## 🤨 Rationale With #1519, we can re-introduce initial rows to the table in the Angular example app without failing the Lighthouse accessibility check. I decided that this was also a good chance to make the tables in the Blazor and Angular example apps consistent with each other. Resolves #1195 Resolves #978 ## 👩💻 Implementation Updated the Blazor and Angular example tables to: - Use consistent models to represent the table data - As part of this, I made the Blazor example app have deterministic data and removed the use of `Faker` - Have the same set of columns and column configuration - Load initially with 10 rows - Add 10 more rows to the table when the _Add rows_ button is pressed ## 🧪 Testing - Ran both example apps and make sure the tables behave identically and have the same data - Verified that the Lighthouse accessibility check passes (part of the pipeline) ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [ ] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: Milan Raj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Add localized labels and titles to remaining elements within the nimble-table.
This is part of #1151
👩💻 Implementation
Add new label tokens for required strings and use them within the table.
🧪 Testing
*As part of this manual check, I found that the labels on our group header icons don't work as expected due to #1510
✅ Checklist