-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLD: API for number-text and date-text table columns #1268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
requested review from
rajsite,
atmgrifter00 and
mollykreis
as code owners
May 23, 2023 21:03
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
mollykreis
reviewed
May 24, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
1 task
jattasNI
commented
May 31, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Show resolved
Hide resolved
rajsite
reviewed
Jun 5, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
msmithNI
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me. Approving but assuming these updates will be made:
- removing
locale
from API, and instead stating it'll be looked up from lang/locale on the theme provider - placeholder being shown for date columns when the value is
null
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
1 task
@mollykreis @atmgrifter00 @rajsite heads up that I've responded to the last open comment threads so this is ready for your next round of review. |
mollykreis
approved these changes
Jun 12, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Outdated
Show resolved
Hide resolved
atmgrifter00
approved these changes
Jun 12, 2023
rajsite
approved these changes
Jun 14, 2023
packages/nimble-components/src/table/specs/table-column-specs/table-column-formatted-text.md
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Need APIs for #1011 and #1014. Builds on #1224.
π©βπ» Implementation
Updates to existing HLD. Philosophy is to rely on the browser's
Intl
formatting APIs when possible and to provide modes with opinionanted configuration and with custom configuration.π§ͺ Testing
N/A
β Checklist