-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to create base classes for table columns that display text #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
changed the title
Refactor to create base class for table columns that display text
Refactor to create base classes for table columns that display text
May 11, 2023
rajsite
reviewed
May 11, 2023
packages/nimble-components/src/table-column/text-base/group-header-view/index.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/text-base/cell-view/index.ts
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/table-column/text/group-header-view/index.ts
Show resolved
Hide resolved
rajsite
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
As part of the vision described in #1224 in service of #1011 and other column types, we will want to share rendering logic across columns that display their data as text. This could eventually include:
👩💻 Implementation
These live in
table-column/text-base
.text
column🧪 Testing
Relying on existing tests.
We have a future task to add docs/examples/tests for applications deriving from these base classes.
✅ Checklist