Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table collapse all #1189

Merged
merged 36 commits into from
Apr 25, 2023
Merged

Table collapse all #1189

merged 36 commits into from
Apr 25, 2023

Conversation

atmgrifter00
Copy link
Contributor

@atmgrifter00 atmgrifter00 commented Apr 17, 2023 •
edited
Loading

Pull Request

🤨 Rationale

👩‍💻 Implementation

Primarily just adding a new button the Table template that, when pressed, will call a TanStack API to collapse all expanded rows. Additionally adding icon to header that represents whether that column is being used to group rows by.

Note that there is now reserved space on the left-side of the table for the button.

🧪 Testing

Added unit tests.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@atmgrifter00 atmgrifter00 requested a review from mollykreis April 17, 2023 18:05
mollykreis
mollykreis reviewed Apr 17, 2023
View reviewed changes
packages/nimble-components/src/table/components/cell/styles.ts Show resolved Hide resolved
change/@ni-nimble-components-997c813b-24bc-4cff-93cf-ebd4a16affd9.json Outdated Show resolved Hide resolved
packages/nimble-components/src/table/components/row/index.ts Outdated Show resolved Hide resolved
packages/nimble-components/src/table/components/row/template.ts Show resolved Hide resolved
packages/nimble-components/src/table/index.ts Outdated Show resolved Hide resolved
packages/nimble-components/src/table/template.ts Outdated Show resolved Hide resolved
packages/nimble-components/src/table/tests/table-column-sizing.spec.ts Outdated Show resolved Hide resolved
packages/nimble-components/src/table/tests/table-column-sizing.spec.ts Outdated Show resolved Hide resolved
packages/nimble-components/src/table/tests/table-grouping.spec.ts Show resolved Hide resolved
packages/nimble-components/src/table/components/header/template.ts Show resolved Hide resolved
@atmgrifter00 atmgrifter00 requested a review from msmithNI as a code owner April 21, 2023 15:20
@atmgrifter00 atmgrifter00 mentioned this pull request Apr 25, 2023
Closed
5 tasks
rajsite
rajsite approved these changes Apr 25, 2023
View reviewed changes
lighthouserc.js Outdated Show resolved Hide resolved
packages/nimble-components/src/table-column/base/types.ts Outdated Show resolved Hide resolved
@atmgrifter00 atmgrifter00 merged commit 6c2fa63 into main Apr 25, 2023
@atmgrifter00 atmgrifter00 deleted the table-collapse-all branch April 25, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollykreis mollykreis mollykreis approved these changes

@jattasNI jattasNI jattasNI approved these changes

@rajsite rajsite rajsite approved these changes

@msmithNI msmithNI Awaiting requested review from msmithNI

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atmgrifter00 @rajsite @jattasNI @mollykreis