Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table row selection angular #1186

Merged
merged 5 commits into from
Apr 20, 2023
Merged

Table row selection angular #1186

merged 5 commits into from
Apr 20, 2023

Conversation

mollykreis
Copy link
Contributor

Pull Request

🀨 Rationale

Add Angular support for row selection in the table, which is part of #856.

πŸ‘©β€πŸ’» Implementation

  • Add selectionMode to the table's directive
  • Add getSelectedRowIds() and setSelectedRowIds() to the table's directive
  • Update the Angular example app to configure a selection mode of multiple
  • Update the Angular example app to render with 0 rows in the table because there are Lighthouse failures otherwise
    • This is not an ideal solution (nor a long-term solution). However, we decided it did not make sense to block adding Angular support for row selection on Lighthouse failures, particularly when we already have an issue to track accessibility issues with the table -- Address Table accessibility issuesΒ #1151

πŸ§ͺ Testing

  • Added/ran unit tests
  • Verified table worked correctly in example app

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis mollykreis merged commit b569273 into main Apr 20, 2023
@mollykreis mollykreis deleted the table-row-selection-angular branch April 20, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants