-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up process to modify design tokens #1183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
commented
Apr 12, 2023
fredvisser
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dev workflow for base tokens is much more straightforward, and worked well in my testing. I have no further feedback - 👍
rajsite
reviewed
Apr 17, 2023
packages/nimble-components/src/theme-provider/tests/color.stories.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Apr 17, 2023
rajsite
approved these changes
Apr 17, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
This started as a joke to modify some token values but turned into refactoring how we source our design tokens when I wrapped my head around the problems with our current approach:
dist
directory when they should be sourceThe new approach is to remove DSP, make Style Dictionary JSON files in this repo our source of truth for design token values, and generate token output as part of the build.
The changes I'm making here should make #1175 easier too. (The Figma plugin linked in that issue can output Style Dictionary JSON files).
👩💻 Implementation
source
directory. This required some changes to get lint to pass since some of these files weren't previously linted. (See comments in PR)npm run build
instead of checking it in to source🧪 Testing
Made token changes and verified that the built components uptake them.
✅ Checklist