Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[High Priority] Client generator: provide support backward compatibility for Older libraries #949

Conversation

Jotheeswaran-Nandagopal
Copy link
Contributor

What does this Pull Request accomplish?

  • Replace resolve_service API with resolve_service_with_information API, to get the version of the measurement along with service location.

Why should this Pull Request be merged?

  • The Measurement Plug-In client lacks backward compatibility for measurements that use older libraries, as the versions are set to 0.0.1 by the recent updates in the discovery service.
  • This implements contains the fetching of the measurement version from the ServiceDescriptor of resolve_service_with_information API, which solves the backward compatibility issue.
    Context - Measurement client Generator does not support backward compatability for Older libraries #946

What testing has been done?

  • Done manual testing.
  • Existing automated tests passed.

… into users/jothees/client-generator-backward-compatibility
Base automatically changed from users/jothees/add-resolve-service-with-information-api to main September 26, 2024 19:27
Copy link

github-actions bot commented Sep 26, 2024

Test Results

    40 files  ±0      40 suites  ±0   54m 5s ⏱️ + 1m 29s
   698 tests ±0     698 ✅ ±0      0 💤 ±0  0 ❌ ±0 
16 980 runs  ±0  15 910 ✅ ±0  1 070 💤 ±0  0 ❌ ±0 

Results for commit c52ddef. ± Comparison against base commit 801220f.

♻️ This comment has been updated with latest results.

@Jotheeswaran-Nandagopal
Copy link
Contributor Author

Pipeline is failing, because the ni_measurement_plugin_sdk_service dependency is taken from cache, instead of installing a updated service (#941), which throws grpc.StatusCode.UNIMPLEMENTED .

@bkeryan
Copy link
Collaborator

bkeryan commented Sep 26, 2024

Pipeline is failing, because the ni_measurement_plugin_sdk_service dependency is taken from cache, instead of installing a updated service (#941), which throws grpc.StatusCode.UNIMPLEMENTED .

I expected #944 to fix this. Please merge/rebase the latest main into your branch to be sure.

@Jotheeswaran-Nandagopal
Copy link
Contributor Author

Jotheeswaran-Nandagopal commented Sep 26, 2024

I expected #944 to fix this. Please merge/rebase the latest main into your branch to be sure.

Yes, I have merged the latest main and the changes in #944 , are added to this branch.

@bkeryan
Copy link
Collaborator

bkeryan commented Sep 27, 2024

I expected #944 to fix this. Please merge/rebase the latest main into your branch to be sure.

Yes, I have merged the latest main and the changes in #944 , are added to this branch.

I think the problem is that measlinkbot is not running the latest release of InstrumentStudio. @MounikaBattu17 rebuilt the measlinkbot images in late August but only deployed the lv64 one. The py32 and py64 images from August have never been launched, and the runner is still using an image from May. I will rebuild and deploy the py32 and py64 images.

@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal merged commit 992c280 into main Sep 27, 2024
17 checks passed
@Jotheeswaran-Nandagopal Jotheeswaran-Nandagopal deleted the users/jothees/client-generator-backward-compatibility branch September 27, 2024 12:55
Jotheeswaran-Nandagopal added a commit that referenced this pull request Sep 27, 2024
…ity for Older libraries (#949)

* fix: get version details from the resolve service with information api in the client generator

(cherry picked from commit 992c280)
bkeryan pushed a commit that referenced this pull request Sep 27, 2024
… support backward compatibility for Older libraries (#949) (#951)

[High Priority] Client generator: provide support backward compatibility for Older libraries (#949)

* fix: get version details from the resolve service with information api in the client generator

(cherry picked from commit 992c280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Measurement client Generator does not support backward compatability for Older libraries
4 participants