Close sideband socket gracefully when closing the grpc server #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR won't go in unless the sideband changes go in which adds a new parameter. After that, we will update to latest sideband repo.
What does this Pull Request accomplish?
We need to close the sideband socket when grpc-server shuts down gracefully. Hence, this PR adds support for it.
Why should this Pull Request be merged?
To the sideband codebase, we will pass a boolean variable by reference to the sideband function, which will act as a trigger for closing the socket. The sideband socket will be closed whenever this boolean is set to true.
What testing has been done?
When closing the grpc-server, the sideband socket also closes.
(Will we update the message shown later on in the sideband repo)