Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging Neil's most recent work from walton branch to main #89

Closed
wants to merge 19 commits into from

Conversation

ThomUK
Copy link
Collaborator

@ThomUK ThomUK commented Oct 15, 2024

2 tests commented out (function is no longer vectorised)
Cran checks not passing (1 error, 3 warnings, 2 notes)

Propose merging to main to allow clean re-start to issue fixes from a single branch (main)

@ThomUK ThomUK requested a review from chrismainey October 15, 2024 21:01
@ThomUK
Copy link
Collaborator Author

ThomUK commented Nov 7, 2024

Closing PR as discussed in project meeting. Neil to merge additional branches and raise new PR.

@ThomUK ThomUK closed this Nov 7, 2024
@Lextuga007
Copy link
Member

@ThomUK Just to tie this in with the failed gh action, did it fail from this PR which isn't being used now? Thanks

@ThomUK
Copy link
Collaborator Author

ThomUK commented Nov 8, 2024

Hi @Lextuga007, Neil is working at pace developing the package. His work feeding this PR was branched from main a long time ago, and my merge conflict resolution skills were not sufficient to sort it all out. Neil has since done more development locally (features and bugfixes), so he's going to merge all that together and make another PR which will replace this one.

@Lextuga007
Copy link
Member

Lextuga007 commented Nov 8, 2024

Great update! I wasn't sure if the gh action needed an issue but this sounds like it was just related to the PR. Also answers a query in the Slack about the stability of the package and use which is great, thank you!

@chrismainey chrismainey deleted the walton branch November 26, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants