iwlib/utils.h: Avoid leaking reference to object #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't decrement the reference count of the object we insert into the dictionary then we will leak the object later. http://nedbatchelder.com/blog/200911/memory_leak_mystery.html
|
Thanks Will! I've been run off my feet recently with moving, but I'll try to look at this over the weekend. For what it's worth, I do have a branch for moving to CFFI instead, which would mean no more reference count shenanigans. Maybe it's time I start trying to push that out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't decrement the reference count of the object we insert into
the dictionary then we will leak the object later.
http://nedbatchelder.com/blog/200911/memory_leak_mystery.html