addShape

nglviewer · Jun 20, 2024 · 03f77d0 · 03f77d0
1 parent 6a2c2a1
commit 03f77d0
Showing 1 changed file with 4 additions and 17 deletions.
diff --git a/js/src/widget_ngl.ts b/js/src/widget_ngl.ts
@@ -755,25 +755,12 @@ class NGLView extends widgets.DOMWidgetView{
 
     addShape(name: string, shapes: any[]) {
         const shape = new NGL.Shape(name);
-        const shapeDict = {
-            'sphere': shape.addSphere,
-            'ellipsoid': shape.addEllipsoid,
-            'cylinder': shape.addCylinder,
-            'cone': shape.addCone,
-            'mesh': shape.addMesh,
-            'arrow': shape.addArrow,
-            'text': shape.addText,
-            'label': shape.addText,
-            'tetrahedron': shape.addTetrahedron,
-            'octahedron': shape.addOctahedron,
-            'torus': shape.addTorus
-        };
-
         shapes.forEach(([shapeType, ...params]) => {
-            const func = shapeDict[shapeType];
-            func.apply(shape, params);
+            const func = shape[shapeType];
+            if (func && typeof func === 'function') {
+                func.apply(shape, params);
+            }
         });
-
         const shapeComp = this.stage.addComponentFromObject(shape);
     }