Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge dev branch into master (network segregation feature) #739

Closed
wants to merge 7 commits into from
Closed

Merge dev branch into master (network segregation feature) #739

wants to merge 7 commits into from

Conversation

buchdag
Copy link
Member

@buchdag buchdag commented Dec 23, 2020

The PR merge the segregation by network feature by @SilverFire to the master branch.

@SilverFire could you review the PR / test the dev Docker image and tell me if everything seems fine ?

@buchdag buchdag added the kind/feature-request Issue requesting a new feature label Dec 23, 2020
@buchdag buchdag changed the title Dev Merge dev branch into master (network segregation feature) Dec 23, 2020
@buchdag buchdag mentioned this pull request Dec 23, 2020
Closed
@SilverFire
Copy link
Contributor

Seems to be absolutely fine.

The test is the same as in my PR and tests are green on GitHub Actions.
You want me to run tests locally?

@buchdag
Copy link
Member Author

buchdag commented Dec 23, 2020

You want me to run tests locally?

Maybe pulling the new dev image and checking that the feature still work as you intended ? That's probably not really necessary, but I'd prefer to be sure that I did not mess anything.

@buchdag
Copy link
Member Author

buchdag commented Dec 25, 2020

Resolved a merge conflict with #740

@buchdag
Copy link
Member Author

buchdag commented Jan 4, 2021

Resolved a merge conflict in the docs with #743 and #744

Ping @SilverFire, were you able to test your setup with the new dev image ?

@buchdag buchdag added type/feat PR for a new feature and removed kind/feature-request Issue requesting a new feature labels Jun 15, 2021
@SilverFire SilverFire mentioned this pull request Apr 28, 2022
Open
@SilverFire
Copy link
Contributor

Close in favor of #957, please

@buchdag buchdag closed this Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/feat PR for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buchdag @SilverFire