Baseline validation #93
Conversation
add baseline Validation for ARCs in case no specific validation package is referenced
|
@kMutagene Check this out please! I am happy do change anything you say needs a rework. |
- Rename BaselineValidation -> ARCSpecification - Rename isaLight -> V2_Draft - Outsource the Expect functions from V2_Draft to the ValidateAPI - Remove metadata section from ARCSpecification - Remove the confusing checkForParam function - Revert unneeded Changes to the arc-validate.fsproj
Add Mac specific DS_Store files
Add test for ARCSpecification V2_Draft.
|
Hey @kMutagene, |
|
@LibraChris please double check that path that fails in ci. Something like that failing on linux but passing on windows often means that there is a lowercase/uppercase mistake in the path. |
You are 100% correct. But strange that it worked on Mac. |
Fix test path
| let runSummery = ARCExpect.Execute.Validation cases | ||
|
|
||
| //false None (ParseResults<ARCValidate.CLIArguments.ValidateArgs>.Empty) | ||
| Expect.isTrue |
There was a problem hiding this comment.
As you can see in the case of the other tests, in this test project we do not test library functions but the execution of the tool. In this case, a test for arc-validate validate is needed. This test however is completely valid once it has been moved into ARCExpect.Tests
- Move ARCSpecification into ARCExpect - Move Tests and relevant test files in respect - Rename ARCValidate.ARCSpecification. V2_Draft. testCases -> ARCExpect.ARCSpecification. V2_Draft .validationCases - Remove internal keyword from V2_Draft modules - Fixed typos
|
Hey @kMutagene , I addressed the changes you requested. Let me know if it looks good. |
- Fix Error Message in tests - Change Usage of Validation Pipeline to its components - Removed redundant references in fsproj
|
@kMutagene How about now? |
src/arc-validate/APIs/ValidateAPI.fs
Outdated
| let outDirBadge = System.IO.Path.Combine(root, "ARC_specification_V2_Draft.svg") | ||
| let outDirResXml =System.IO.Path.Combine(root, "ARC_specification_V2_Draft.xml") | ||
|
|
||
| ARCExpect.Execute.ValidationPipeline(jUnitPath=outDirResXml, badgePath=outDirBadge,labelText="ARC specification V2_Draft") cases |
There was a problem hiding this comment.
This line (ARCExpect.Execute.ValidationPipeline) still has to go. Now you are validating and writing 2 result files 2 times each.
There was a problem hiding this comment.
Sorry @kMutagene , I didn´t notice that I left it in. Now its removed.
as seen in nfdi4plants#93
Add baseline Validation for ARCs in case no specific validation package is referenced