Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ncbench #1266

Merged
merged 8 commits into from
Oct 4, 2023
Merged

Ncbench #1266

merged 8 commits into from
Oct 4, 2023

Conversation

FriederikeHanssen
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Oct 2, 2023 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 13c23fc

+| ✅ 147 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   1 tests had warnings |!
-| ❌   1 tests failed       |-

❌ Test failures:

Failed validating 'oneOf' in schema[0]['additionalProperties']:
{'oneOf': [{'type': 'string'}, {'type': 'number'}, {'type': 'boolean'}]}

On instance['ZENODO_DEPOSIT_ID']:
None

❗ Test warnings:

  • pipeline_todos - TODO string in WorkflowSarek.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-04 19:33:31

maxulysse
maxulysse reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@FriederikeHanssen FriederikeHanssen changed the base branch from dev to ncbench October 4, 2023 19:51
@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review October 4, 2023 19:51
@FriederikeHanssen FriederikeHanssen merged commit 8eaf157 into nf-core:ncbench Oct 4, 2023
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FriederikeHanssen @maxulysse