Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 1.1.1 #26

Merged
merged 31 commits into from
Dec 18, 2024
Merged

Release version 1.1.1 #26

merged 31 commits into from
Dec 18, 2024

Conversation

charles-plessy
Copy link
Collaborator

@charles-plessy charles-plessy commented Dec 17, 2024

1.1.1 release with template update (2.14.1 -> 3.1.0) and Nextflow minimal version update (23.04.0 -> 24.10.1). No changes to the nf-core modules or the workflows other than related to the template update. The local module was fixed to use a version of jq that is available for conda. Thanks to @sateeshperi for suggestions on Slack during the preparation of this PR.

edit: I just remembered that this will fix issue #23.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/pairgenomealign branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

nf-core-bot and others added 25 commits October 8, 2024 12:32
Co-authored-by: James A. Fellows Yates <[email protected]>
Important! Template update for nf-core/tools v3.0.2
> :nf-core:  Friday, December 13th 11:01 PM
> :alert: @channel the last tools release removed the includeConfig 'conf/modules.config' from the nextflow.config file. A patch release is on the way, meanwhile don't accept this change and don't remove this line!
> thanks and sorry for the inconvenience 🙏:skin-tone-2:
Important! Template update for nf-core/tools v3.1.0
I did not commit the removal of the contributor information in
ro-crate-metadata.json, which was probably caused by a bug in
nf-core rocrate that does not recognise the 24.10.0 format of
contributor attribution.
@charles-plessy charles-plessy changed the title Dev Release version 1.1.1 Dec 17, 2024
charles-plessy and others added 4 commits December 17, 2024 16:00
Only this version is simultaneously available for Conda, Docker and
Singularity.

The local module only uses `jq -r` which is a simple command with
same output in 1.5 and 1.6.
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And no comments 😱

@charles-plessy charles-plessy merged commit 0c1a6b9 into master Dec 18, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants