Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dragmap): Rollback to 1.2.1 #2761

Merged
merged 2 commits into from
Jan 22, 2023
Merged

fix(dragmap): Rollback to 1.2.1 #2761

merged 2 commits into from
Jan 22, 2023

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller self-assigned this Jan 21, 2023
@edmundmiller edmundmiller added the bug Something isn't working label Jan 21, 2023
alyssa-ab
alyssa-ab approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@alyssa-ab alyssa-ab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good based on my understanding.
Might need to look into the failing conda checks

@maxulysse maxulysse merged commit 5cef12b into master Jan 22, 2023
edmundmiller added a commit to nf-core/nascent that referenced this pull request Jan 22, 2023
@edmundmiller
chore: Remove dragmap align patch
08869ed 
nf-core/modules#2761
@edmundmiller edmundmiller deleted the rollback-dragmap branch January 22, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssa-ab alyssa-ab alyssa-ab approved these changes

@maxulysse maxulysse maxulysse approved these changes

@nservant nservant Awaiting requested review from nservant

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen

Assignees

@edmundmiller edmundmiller

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edmundmiller @maxulysse @alyssa-ab