Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.13.1 #194

Merged
merged 14 commits into from
Mar 8, 2024
Merged

Important! Template update for nf-core/tools v2.13.1 #194

merged 14 commits into from
Mar 8, 2024

Conversation

nf-core-bot
Copy link
Member

Version 2.13.1 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.13.1 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v2.13.1 release page.

@edmundmiller edmundmiller self-assigned this Mar 5, 2024
@edmundmiller edmundmiller requested a review from nservant March 6, 2024 04:40
@edmundmiller edmundmiller linked an issue Mar 6, 2024 that may be closed by this pull request
NFCORE_HIC:HIC:CUSTOM_DUMPSOFTWAREVERSIONS (1) terminated with an error exit status (1) #182
Closed
@edmundmiller edmundmiller added this to the version-2.2.0 milestone Mar 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1af16a5

+| ✅ 185 tests passed       |+
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Create channel from input file provided through params.input
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-03-08 19:00:17

@edmundmiller edmundmiller requested a review from maxulysse March 7, 2024 21:09
@edmundmiller
Copy link
Contributor

The plan is to merge this, then follow up with editorconfig and linting fixes. Trying to keep the things that could go wrong to a minimum.

nservant
nservant approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@nservant nservant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of changes here !
Looks ok to me

@nservant
Copy link
Collaborator

nservant commented Mar 8, 2024

@edmundmiller, will you fix the linting issue before merging ?

@edmundmiller edmundmiller merged commit 9dcebc4 into dev Mar 8, 2024
3 of 4 checks passed
@edmundmiller
Copy link
Contributor

edmundmiller commented Mar 8, 2024 •
edited
Loading

Fixed! Left the pre-commit failures, I'll follow up with those.

@edmundmiller edmundmiller deleted the nf-core-template-merge-2.13.1 branch March 8, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nservant nservant nservant approved these changes

@maxulysse maxulysse Awaiting requested review from maxulysse

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
version-2.2.0
Development

Successfully merging this pull request may close these issues.

NFCORE_HIC:HIC:CUSTOM_DUMPSOFTWAREVERSIONS (1) terminated with an error exit status (1)
3 participants
@nf-core-bot @edmundmiller @nservant