chore(infra): add missing callback invocation for lambda@edge function #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function conditionally rewrites non-gz URLs to gz. The zip files are conditionally excluded. However, in case o zip file the "done" callback was not called at the end of the function, so the response was incorrect. Here I add the callback invocation at the end of the function, so that requests for zip files are correctly replied to.
ivan-aksamentov
changed the title
ivan-aksamentov
added a commit
that referenced
this pull request
Mar 7, 2022
After #24 there was 2 callback invocations for the base on non-zip files. This removes the redundant call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves nextstrain/nextclade#744
This function conditionally rewrites non-gz URLs to gz. The zip files are conditionally excluded. However, in case of zip file the "done" callback was not called at the end of the function, so the response was incorrect.
Here I add the callback invocation at the end of the function, so that requests for zip files are correctly replied to.
I deployed the new function (version 2) to all 3 environments
Test:
Followup: #25