Use accession for node name but display strain #275
+18
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a companion commit to changes in Auspice <nextstrain/auspice#1668> which allow any node-attr to be used as the tip label and which displays this tip label in the node hover/click boxes as well as alongside nodes (at suitable zoom levels). This allows us to drop the `set_final_strain_name` script and ensures all node names are unique which improves the behaviour of Auspice This commit only changes the Nextstrain datasets, not the Nextclade ones
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion commit to changes in Auspice nextstrain/auspice#1668 which allow any node-attr to be used as the tip label and which displays this tip label in the node hover/click boxes as well as alongside nodes (at suitable zoom levels). This allows us to drop the
set_final_strain_namescript and ensures all node names are unique which improves the behaviour of AuspiceThis commit only changes the Nextstrain datasets, not the Nextclade ones
When viewed on a version of Auspice without the companion changes an error is printed to the console "Invalid JSON-defined tip label: strain" and we fall back to using the
node.name(accession) as the tip label.Testing datasets available at: