Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin pulp<2.8, required by snakemake #53

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix: pin pulp<2.8, required by snakemake #53

merged 1 commit into from
Jan 12, 2024

Conversation

corneliusroemer
Copy link
Member

Pulp 2.8.0 breaks snakemake.
We need to pin until we upgrade snakemake to a version that is compatible with recent versions of pulp again. See snakemake/snakemake#2607 We might need to make a similar change to docker-base

Pulp 2.8.0 breaks snakemake.
We need to pin until we upgrade snakemake to a version that is compatible with recent versions of pulp again.
See snakemake/snakemake#2607
We might need to make a similar change to docker-base
corneliusroemer added a commit to nextstrain/docker-base that referenced this pull request Jan 12, 2024
@corneliusroemer corneliusroemer merged commit 75b5dc6 into main Jan 12, 2024
21 checks passed
@corneliusroemer corneliusroemer deleted the pin-pulp branch January 12, 2024 19:23
victorlin added a commit that referenced this pull request Jan 12, 2024
This reverts commit 75b5dc6.

To check if test-pathogen-repo-ci fails.
@victorlin
Copy link
Member

Without this fix, CI errors during Nextstrain CLI setup in each test-pathogen-repo-ci job:

Checking setup…
✔ yes: operating system is supported
✔ yes: runtime data dir doesn't have spaces
✔ yes: runtime appears set up
✘ no: snakemake is installed and runnable
✔ yes: augur is installed and runnable
✔ yes: auspice is installed and runnable

Checks failed!  Setup is unlikely to be fully functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants