Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nextclade2 #48

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add nextclade2 #48

merged 2 commits into from
Jan 16, 2024

Conversation

victorlin
Copy link
Member

Description of proposed changes

The newest version of nextclade contains a symlink to nextclade2.¹ This will eventually replaced with a symlink to nextclade3.

To continue availability of nextclade2, add a package that provides the nextclade2 binary.²

¹ bioconda/bioconda-recipes@c20aa93
² bioconda/bioconda-recipes@b08d5c6

Related issue(s)

Checklist

  • Checks pass

It has been removed from the Docker image.¹

¹ <nextstrain/docker-base@f49abf9>
The newest version of nextclade contains a symlink to nextclade2.¹ This
will eventually replaced with a symlink to nextclade3.

To continue availability of nextclade2, add a package that provides the
nextclade2 binary.²

¹ <bioconda/bioconda-recipes@c20aa93>
² <bioconda/bioconda-recipes@b08d5c6>
@victorlin victorlin self-assigned this Dec 16, 2023
@corneliusroemer
Copy link
Member

I'm not sure what will happen when we have two times the same binary. Once as a symlink to Nextclade and once as a binary itself.

Will conda notice and complain? It probably should.

Nextclade==2.* and nextclade2 should be mutually exclusive, there might be a way to encode this into conda.

@victorlin
Copy link
Member Author

The nextstrain-base package builds fine, but there is a warning when installing it and linking dependencies:

warning  libmamba [nextclade2-2.14.0-h9ee0642_0] The following files were already present in the environment:
    - bin/nextclade2

I don't see why they should be made mutually exclusive. While both of them contain nextclade2, those are functionally identical so it doesn't matter that one overwrites the other. Once nextclade no longer has nextclade2 but instead has nextclade3, this allows what is currently supported in the Docker image - access to both nextclade2 and nextclade3.

@corneliusroemer
Copy link
Member

Yep this should work - though the warning is a little annoying. Up to you whether we wait or not with merging.

@corneliusroemer
Copy link
Member

We should merge this PR soon (tomorrow) so that nextclade2 remains available when we release nextclade(3) on bioconda tomorrow

@victorlin victorlin merged commit 141482e into main Jan 16, 2024
19 of 20 checks passed
@victorlin victorlin deleted the victorlin/add-nextclade2 branch January 16, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants