Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request provides two items:
The "better connection" means that it does not rely on
constants.MINIONREDISHOST
. For me that failed. Instead, usesStrictRedis(host='minionredis_1')
, which is (as @dconathan mentioned) a somewhat old docker feature that we're not up to date on. @LiamIm didconstants.MINIONREDISHOST
work for you?This also adds the functions
increment
,append
,get_many
,set_many
andpipeline
to Butler.Memory. It also refactorsset
andget
to useast.literal_eval
to return the stored objects.It cleans the API by using function wrappers to ensure the connection and catch exceptions. Before, all of these were coded in every function.
This implementation can be tested in the docker container with
All tests pass.