Start language server via nextflow lsp
#47
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on nextflow-io/nextflow#5466
Launch the language server via
nextflow lsp
instead of launching the JAR directly. This way, the extension will use whatever language server corresponds to the active nextflow version.We will likely need to keep the old java launcher as a fallback, since Nextflow versions <=24.10 do not have an
lsp
command. However, we could improve this code by downloading the language server JAR from GitHub instead of bundling it with the extension. That way, I don't even need to publish the VS Code extension to push updates, I can just publish the language server and ask users to restart.