Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace view with dump #450

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FriederikeHanssen
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit 8c2a69d
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/673753c281e94300089d4a6d
😎 Deploy Preview https://deploy-preview-450--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pinin4fjords
pinin4fjords previously approved these changes Nov 15, 2024
Copy link
Collaborator

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sold on the dump thing, I quite often chuck views in as a lightweight thing in development. I have no intention of leaving them there, so dump isn't all that useful, and I have to do something extra on the command line.

... but I saw on Slack that this is the consensus view, so I'm fine with it.

```

As you can see, the flatten() operator has transformed the channel from containing arrays to containing individual elements. This can be useful when you want to process each item separately in your workflow.

Remove the `.view()` operations before you continue.
Remove the `.dump()` operations before you continue.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don't need to with dump?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased to make it optional. I am terrified of updating all line numbers everywhere.

Copy link
Collaborator

@adamrtalbot adamrtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm with @pinin4fjords, not 100% keen on dump replacing view here, it seems more work than necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants