Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the 'Your first script' section. #294

Merged
merged 10 commits into from
Dec 11, 2023

Conversation

ewels
Copy link
Member

@ewels ewels commented Dec 11, 2023

  • Bit more verbose description of what the script is actually doing
  • Mini subsection switching the (often unfamiliar) bash commands with some Python

* Bit more verbose description of what the script is actually doing
* Mini subsection switching the (often unfamiliar) bash commands with some Python
Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit cace0e4
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/6576f30ebd7f0a00082396b2
😎 Deploy Preview https://deploy-preview-294--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small edit but otherwise looks great

docs/basic_training/intro.md Outdated Show resolved Hide resolved
Co-authored-by: Christopher Hakkaart <[email protected]>
docs/basic_training/intro.md Outdated Show resolved Hide resolved
@ewels
Copy link
Member Author

ewels commented Dec 11, 2023

Ok, there's something a bit broken with the current versions of mamba + conda somehow. Switching out mamba back to conda in the Dockerfile seems to fix the build. Mamba is still installed, so hopefully it shouldn't affect usage inside the container (as we have a bunch of written training material talking about using it).

@ewels ewels merged commit 6667683 into nextflow-io:master Dec 11, 2023
6 checks passed
@ewels ewels deleted the intro-example-python branch December 11, 2023 11:33
@ewels ewels restored the intro-example-python branch December 11, 2023 11:33
@ewels ewels deleted the intro-example-python branch December 11, 2023 11:33
@ewels
Copy link
Member Author

ewels commented Dec 11, 2023

@mribeirodantas - note some small changes here that are not ported over into the translations. Sorry about that! Shout if I should mark this somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants