Move the help message code to an observer #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #52 |
mirpedrol
approved these changes
Jan 7, 2025
| nextflow.validation.ValidationExtension | ||
| nextflow.validation.ValidationObserverFactory |
There was a problem hiding this comment.
just to doubleckeck, ValidationObserver doesn't have to be added?
There was a problem hiding this comment.
Nope the factory creates the observer so it gets implemented that way :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the help message code from the extension point to an observer. This will fix the occassion when a user only wants to use the help message without using any functions of the plugin.
Previously the help message would only be created once a function was imported.
This PR also updates some class names to have them make more sense.