-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic highlighting #92
Conversation
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
I think this is good enough for a first implementation. It mainly distinguishes variables/properties from functions, and improves highlighting for string interpolations. In the config, it better distinguishes config settings from dynamic expressions and code.
"[nextflow]": {
"editor.semanticHighlighting.enabled": false
}
|
Awesome! 👏🏻 🎉 |
Close #8
Semantic tokens are used on top of the syntax highlighting, so the language server need only override tokens which aren't accurately described by the TextMate grammar.
The encoding of semantic tokens is described here
The first pass just tries to provide semantic token types for named symbols like variable/function names. Some things to improve: