Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trailing dot on arbitrary expressions #77

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

bentsherman
Copy link
Member

Enables auto-completion on more kinds of expressions, for example:

Channel.of(1, 2, 3). // map, filter, collect...

The challenge is that expression also allows incompleteExpression, but the inner expression of incompleteExpression should not allow further incomplete expressions.

The current changes to the script parser feel messy and also are incomplete. It would probably be better to parametrize the expression rule with a flag for whether the incompleteExpression is allowed.

@bentsherman bentsherman marked this pull request as ready for review November 26, 2024 20:26
@bentsherman bentsherman merged commit a641cf5 into main Nov 26, 2024
1 check passed
@bentsherman bentsherman deleted the incomplete-expressions branch November 26, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant