-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split into subprojects for compiler and language server #73
Conversation
Signed-off-by: Ben Sherman <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
I added a convention plugin and a task to copy the shadow JAR to the top-level Now I am testing the gradle build for the vs code extension and getting this error:
The vs code extension has this rootProject.name = 'vscode-language-nextflow'
include 'language-server' And this gradle task to copy the shadow JAR into the extension build: task copyJar(type: Copy) {
dependsOn ':language-server:build'
from "$projectDir/language-server/build/libs/language-server-all.jar"
into "$buildDir/bin"
} For some reason, gradle can't find the |
I need to keep moving with other things so I'm going to merge what I have for now. I can make it work by manually building the language server JAR and only copying it from the vs code build: // settings.gradle (vs code extension)
rootProject.name = 'vscode-language-nextflow'
// include 'language-server'
// build.gradle (vs code extenstion)
task copyJar(type: Copy) {
// dependsOn ':language-server:build'
from "$projectDir/language-server/build/libs/language-server-all.jar"
into "$buildDir/bin"
} # from the vs code repo
cd language-server
./gradlew build
cd ..
./gradlew build I suspect there is just something wrong in the language server gradle build. If either of you have any more pointers or can spot the issue, please let me know |
The build seems to work:
And produces the following files:
But the manifest seems to be wrong:
I think something is wrong with the shadow JAR build, even though I didn't change any settings for it in the gradle build