Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "tertiary no background" as type for the buttons in table's header #6800

Conversation

JuliaKirschenheuter
Copy link
Contributor

πŸ“ Summary

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
Screenshot from 2024-12-18 17-36-46 Screenshot from 2024-12-18 17-36-04

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 46.79%. Comparing base (8586891) to head (f99849a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6800      +/-   ##
==========================================
+ Coverage   46.76%   46.79%   +0.02%     
==========================================
  Files         748      733      -15     
  Lines       34162    34142      -20     
  Branches     1242     1227      -15     
==========================================
  Hits        15976    15976              
+ Misses      17564    17559       -5     
+ Partials      622      607      -15     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@juliusknorr
Copy link
Member

Both failures are unrelated.

@juliusknorr juliusknorr merged commit d45b8e0 into main Dec 18, 2024
61 of 64 checks passed
@juliusknorr juliusknorr deleted the fix/6152--Can-use-tertiary-no-background-as-type-for-the-buttons branch December 18, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants