fix(licenses): SPDF license in package.json and khroma #6790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6790 +/- ##
=======================================
Coverage 46.86% 46.86%
=======================================
Files 747 747
Lines 34012 34012
Branches 1240 1240
=======================================
Hits 15940 15940
Misses 17451 17451
Partials 621 621 ☔ View full report in Codecov by Sentry. |
khroma has a MIT `license` file but nothing set in their package.json. `rollup-license-plugin` seems to not understand that. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
fix/package-license
branch
from
f629a6b to
4a7eb05
Compare
|
/backport to stable30 |
|
/backport to stable29 |
mejo-
approved these changes
Dec 16, 2024
|
cypress runner 7 failure is unrelated and known ( #6546 ) |
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
khroma has a MIT
licensefile but nothing set in their package.json.rollup-license-pluginseems to not understand that.🖼️ Screenshots
🏚️ Before
Taken from: https://github.com/nextcloud/text/actions/runs/12349651464/job/34460918124?pr=4902
After: See assets included in this PR.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)