-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): without non deterministic vendor-LICENSE.txt #6539
Conversation
I think we added that on purpose for compliance reasons, but I'm unsure what the current state there is. activity for example also has this disabled and a separate flag but commented out: https://github.com/nextcloud/activity/blame/master/vite.config.ts#L16-L18 @susnux Any hint there? Is this fine to turn off for now? |
It is ok to do so, but instead enabled |
@max-nextcloud Can you adjust that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs changes
4c9641b
to
54794f0
Compare
54794f0
to
76c8993
Compare
Done. Added |
76c8993
to
0579a12
Compare
Signed-off-by: Max <[email protected]>
0579a12
to
2eea6a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6539 +/- ##
==========================================
+ Coverage 46.26% 47.56% +1.29%
==========================================
Files 746 284 -462
Lines 34452 33515 -937
Branches 1239 777 -462
==========================================
Hits 15940 15940
+ Misses 17892 17417 -475
+ Partials 620 158 -462 ☔ View full report in Codecov by Sentry. |
@max-nextcloud I think this broke reuse compliance, can you check that? Seems it only happend on main as the committed assets were only updated there. |
@juliusknorr ahh... I was wondering what broke it. I'll take a look |
/backport to stable30 |
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/6539/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2eea6a29
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6539/stable30 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The content of
vendor.LICENSE.txt
is not deterministic.If two versions of one library are imported
one of them will be picked and listed in the file.
This results in arbitrary changes to the file
which in turn create npm fix audit PRs such as #6534.
See also: https://nextcloud-libraries.github.io/nextcloud-vite-config/interfaces/BaseOptions.html#thirdPartyLicense