-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable28] Check link protocol #6491
base: stable28
Are you sure you want to change the base?
Conversation
This backport is more involved as we did not have the link bubble yet in 28. |
6ddc2bf
to
dde09dd
Compare
I think the backport is fine now - I'm still unsure though if this is really the behavior we want. Probably not so bad anyway though as 28 is pretty old and from 29 on we have the link bubble. |
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
dde09dd
to
ca93aa1
Compare
Cypress component tests seem to fail fairly reliable. |
Maybe they did break with #6501 ? Before that stable28 seemed fine https://github.com/nextcloud/text/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Amerged+base%3Astable28 |
Good catch. |
Okay... so i see several options how to handle this:
They all seem somewhat cumbersome. In addition this issue does not show on current versions as we are using vite there I believe. |
I'd go with 1 for the stable branch for now to get this pr in |
Backport of #6486
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.