Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Skip files list in sharing tests #5573

Merged
merged 1 commit into from
Mar 26, 2024
Merged

chore: Skip files list in sharing tests #5573

merged 1 commit into from
Mar 26, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 26, 2024

Planned to debug the failing test, and seems removing an unrelated speed up stabilizes them already. Seems to pass during a few pushes

We can skip loading the files list in as we don't need it when the share request is done through the API.

@juliusknorr

This comment was marked as outdated.

@juliusknorr juliusknorr marked this pull request as ready for review March 26, 2024 16:35
@juliusknorr juliusknorr requested review from mejo- and grnd-alt March 26, 2024 16:36
@juliusknorr juliusknorr added tests If you write them we ♥ you 3. to review labels Mar 26, 2024
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@juliusknorr
Copy link
Member Author

Ok, celebrated too early. Will merge anyways as it speeds up the test runs

@juliusknorr juliusknorr merged commit c18e128 into main Mar 26, 2024
58 of 60 checks passed
@juliusknorr juliusknorr deleted the fix/ci branch March 26, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review tests If you write them we ♥ you
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants