Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(links): set default for loadState('core', 'active-app') #5571

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Mar 26, 2024

Without, it threw an error in public shares, which broke loading pages with links.

@mejo- mejo- added this to the Nextcloud 29 milestone Mar 26, 2024
@mejo- mejo- requested review from juliusknorr and grnd-alt March 26, 2024 10:20
@mejo- mejo- self-assigned this Mar 26, 2024
src/helpers/links.js Outdated Show resolved Hide resolved
Without, it threw an error in public shares, which broke loading pages
with links.

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- changed the title fix(links): catch errors of loadState() in public shares fix(links): set default for loadState('core', 'active-app') Mar 26, 2024
@mejo- mejo- force-pushed the fix/public_shares_links branch from baf477e to 1f74da4 Compare March 26, 2024 11:38
@mejo- mejo- requested a review from juliusknorr March 26, 2024 11:38
@juliusknorr juliusknorr merged commit e4c0fe8 into main Mar 26, 2024
59 checks passed
@juliusknorr juliusknorr deleted the fix/public_shares_links branch March 26, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants