Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HelpModal): Migrate to NcDialog, fix padding #5488

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Mar 14, 2024

Fixes: #5456

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
grafik grafik

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo- mejo- added design Experience, interaction, interface, … 3. to review bug: regression labels Mar 14, 2024
@mejo- mejo- added this to the Nextcloud 29 milestone Mar 14, 2024
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the screenshot but didnt test

@mejo- mejo- merged commit 093ad0d into main Mar 15, 2024
59 checks passed
@mejo- mejo- deleted the fix/formatting_help_dialog branch March 15, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review design Experience, interaction, interface, …
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting help modal needs some padding
2 participants