fix: Use proper way of hiding the attachment input #5230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable28 |
juliusknorr
commented
Jan 11, 2024
| <input ref="attachmentFileInput" | ||
| tabindex="-1" | ||
| <input v-show="false" | ||
| ref="attachmentFileInput" | ||
| data-text-el="attachment-file-input" | ||
| type="file" | ||
| accept="*/*" | ||
| aria-hidden="true" |
There was a problem hiding this comment.
@ShGKme Also do we still need the aria-hidden then or is this already fine with just having display: none; through v-show
There was a problem hiding this comment.
No, display: none (and visibility: hidden) both make element completely hidden.
Let's say, be default element is visible for both monitor's and screen reader's users.
display: none/visibility: hidden- hides element completely for everythingaria-hidden="true"- hides element only for screen readers (meaning, it is not important element, like decorative image)hidden-visually- hides element only visually (meaning, this is only for screen reader or replaces some only visual element)
One specific case when aria-hidden="true" and hidden-visually used together - the prev and next slides in Viewer. They must be hidden, but for image/video pre-loading and because of a bug in FF we need then to not be display: none.
There was a problem hiding this comment.
Thanks, that makes sense ❤️
mejo-
approved these changes
Jan 11, 2024
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/a11y-input-file
branch
from
9179e7b to
31ab596
Compare
ShGKme
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide the input field properly to make it not focusable and hidden for assistive technologies.
as described in #5224 (comment)