Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outline): Make sure the outline is always in foreground #4967

Closed
wants to merge 1 commit into from

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Nov 7, 2023

📝 Summary

Add a border shadow around the outline. Also, make it overlay the editor content (e.g. on small screens). Required e.g. for Collectives.

Fixes: #4276

Copied from #4945 (review):

Having the outline floating without borders was part of the design requirements or feedback when we introduced it, so I'd not change that as part of a bugfix at least.

@nextcloud/designers for feedback from the design team.

🖼️ Screenshots

🏚️ Before Text standalone 🏡 After Text standalone
grafik grafik
🏚️ Before Collectives 🏡 After Collectives
grafik grafik

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

Add a border shadow around the outline. Also, make it overlay the
editor content (e.g. on small screens). Required e.g. for Collectives.

Fixes: #4276

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- added bug Something isn't working design Experience, interaction, interface, … 3. to review labels Nov 7, 2023
@marcoambrosini
Copy link
Member

I think the outline should definitely go in the right sidebar. We cannot add yet another column to collectives (we have 4).

Screenshot 2023-11-08 at 11 21 24

@nimishavijay
Copy link
Member

Agreed with Marco, in Collectives it could go in the sidebar.
In Text, I do still think that we could keep the outline without borders, it blends seamlessly with the rest of the document that way. Otherwise it feels a bit like losing the immersiveness of a full screen text editor, what do you think? :)

@mejo-
Copy link
Member Author

mejo- commented Nov 22, 2023

Let's discuss this separately for collectives. The text related parts are already addressed.

@mejo- mejo- closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working design Experience, interaction, interface, …
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outline div is not scrollable if height bigger than parent
3 participants