fix(link): Don't throw exception on invalid URL href

When pasting strings with invalid URLs, `new URL()` in `renderHTML()` of the Link extension threw an error, which made the paste parser choke. We should catch this exception and handle it gracefully to not break HTML parsing completely with invalid URLs. Signed-off-by: Jonas <[email protected]>
nextcloud · Dec 17, 2024 · 005b208 · 005b208
1 parent ffa9b6b
commit 005b208
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/src/marks/Link.js b/src/marks/Link.js
@@ -60,10 +60,15 @@ const Link = TipTapLink.extend({
 
 	renderHTML(options) {
 		const { mark } = options
-		const url = new URL(mark.attrs.href, window.location)
-		const href = PROTOCOLS_TO_LINK_TO.includes(url.protocol)
-			? domHref(mark, this.options.relativePath)
-			: '#'
+		let href
+		try {
+			const url = new URL(mark.attrs.href, window.location)
+			href = PROTOCOLS_TO_LINK_TO.includes(url.protocol)
+				? domHref(mark, this.options.relativePath)
+				: '#'
+		} catch (error) {
+			href = '#'
+		}
 		return ['a', {
 			...mark.attrs,
 			href,