Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reactions background #4620

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Fix reactions background #4620

merged 7 commits into from
Jan 17, 2025

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jan 16, 2025 •
edited
Loading

  • Fixed color calculation
  • Lowered border radius on background
  • Fixed padding on "non-bubbled" messages' reactions
  • Note: cut-off render issues are due to the screen-shoting tool

Resolves #4557

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot_2025-01-16-15-32-52-25 Screenshot_2025-01-16-15-53-21-83

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added bug Something isn't working design Related to the design 3. to review Waiting for reviews labels Jan 16, 2025
@AndyScherzinger AndyScherzinger force-pushed the fix/4557/reactionsBackground branch from c53262a to a2dac5e Compare January 16, 2025 14:41
@AndyScherzinger AndyScherzinger force-pushed the fix/4557/reactionsBackground branch from 26a3445 to 9e3840c Compare January 16, 2025 15:29
nickvergessen
nickvergessen approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots look much better 🤩

@AndyScherzinger AndyScherzinger added this to the 21.0.0 milestone Jan 16, 2025
miaulalala
miaulalala approved these changes Jan 16, 2025
View reviewed changes
Copy link

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRETTY 😍

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4620-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 779c162 into master Jan 17, 2025
18 checks passed
@mahibi mahibi deleted the fix/4557/reactionsBackground branch January 17, 2025 12:14
@mahibi
Copy link
Collaborator

mahibi commented Jan 17, 2025

great, thank you Andy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@mahibi mahibi mahibi approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design
Projects
None yet
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.

Reaction position and color is wrong and confusing sometimes
4 participants
@AndyScherzinger @mahibi @nickvergessen @miaulalala