Migrating away from java.util.Date to java.time - DateTimePickerFragment

[rapterjet2004]

#4274

Migrating to java.time would remove so much code in DateTimePickerFragment that I figured I might as well also convert the dialog fragment to compose too. Honestly looks and feels way better now.

• Added DateTimeCompose
  • Embedded the Date and Time pickers into the dialog
• Removed DateTimeFragment + XML
• Now uses java.time for all-in-one timezone handling + more robust features, instead of java.util.Calendar and java.util.TimeZone

Core logic

        val laterToday = LocalDateTime.now()
            .withHour(18)
            .withMinute(0)
            .withSecond(0)

        val tomorrow = LocalDateTime.now()
            .plusDays(1)
            .withHour(8)
            .withMinute(0)
            .withSecond(0)

        val thisWeekend = LocalDateTime.now()
            .with(nextOrSame(DayOfWeek.SATURDAY))
            .withHour(8)
            .withMinute(0)
            .withSecond(0)
        
        val nextWeek = LocalDateTime.now()
            .plusWeeks(1)
            .with(DayOfWeek.MONDAY)
            .withHour(8)
            .withMinute(0)
            .withSecond(0)
       

issue-4274.webm

🚧 TODO

• Delete the old fragment + xml
• Making the labels strings res
• Checking the offset from datePicker
• Theming

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[sowjanyakch]

1. I set remainder using custom time and remind me later is always set to 03 Jan, 18:00 pm and it is not updated with the set custom time.

2. Set a custom time for remainder, then try to change the time - use one of the predefined options, the remind me later is not updated.

3. Replace hardcoded strings with stringResource()

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4552-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	158	161
Errors	71	71

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	222	16
Dodgy code	71	71
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	310	104

Lint increased!