Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new notification warner #4504

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Dec 2, 2024

resolve #4501

New UI for show notification warning + add option to show it "Not Now" + change behavior of switch settings.

"Not now" will remind in 5 days again.

πŸ–ΌοΈ Screenshots

before after
grafik grafik

Also, in the settings the text for the switch is changed from "Show notification warning" to "Show regular notification warning"

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • πŸ”– Capability is checked or not needed
  • πŸ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • πŸ“… Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi requested a review from sowjanyakch December 2, 2024 15:02
@mahibi mahibi self-assigned this Dec 2, 2024
@mahibi mahibi added the 3. to review Waiting for reviews label Dec 2, 2024
@mahibi
Copy link
Collaborator Author

mahibi commented Dec 2, 2024

As this change should be included for the 20.1.0 release very soon, it would be great to get some translations for these strings by today:

"Not now"
"Show regular notification warning"
"When notifications are not set up correctly, show a regular warning"

Great would be at least french, spanish & italian to cover some most used languages. I will do it for german.
Just pinging some devs here that could translate. Just post the translation here as comment, i will take care of transifex.

@marinofaggiana
Copy link
Member

Ita:

"Not now"
Non adesso

"Show regular notification warning"
Mostra avviso di notifica regolare

"When notifications are not set up correctly, show a regular warning"
Quando le notifiche non sono impostate correttamente, mostra un avviso regolare

@Ivansss
Copy link
Member

Ivansss commented Dec 2, 2024

Spanish:

"Not now" : "Ahora no"
"Show regular notification warning" : "Mostrar aviso periΓ³dico sobre notificaciones"
"When notifications are not set up correctly, show a regular warning" : "Cuando las notificaciones no estΓ‘n configuradas correctamente, mostrar un aviso periΓ³dico"

@come-nc
Copy link

come-nc commented Dec 2, 2024

French:
"Not now"
->"Plus tard"
(Litteraly "Later", but this is what is usually shown by softwares for this kind of things)
"Show regular notification warning"
-> "Afficher un avertissement rΓ©gulier Γ  propos des notifications"
"When notifications are not set up correctly, show a regular warning"
-> "Quand les notifications ne sont pas correctement configurΓ©es, afficher un avertissement rΓ©gulier"

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi force-pushed the feature/4501/notificationWarningLessProminent branch from ea9e642 to 366c2b5 Compare December 2, 2024 16:33
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Codacy

Lint

TypemasterPR
Warnings158158
Errors7373

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

Copy link
Contributor

github-actions bot commented Dec 2, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4504-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 187f98a into master Dec 2, 2024
18 checks passed
@mahibi mahibi deleted the feature/4501/notificationWarningLessProminent branch December 2, 2024 16:48
@mahibi
Copy link
Collaborator Author

mahibi commented Dec 2, 2024

/backport to stable-20.1

@backportbot backportbot bot mentioned this pull request Dec 2, 2024
2 tasks
@mahibi mahibi added this to the 21.0.0 milestone Dec 2, 2024
@mahibi
Copy link
Collaborator Author

mahibi commented Dec 2, 2024

/backport to stable-20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow dismissing the Notifications are not setup correctly warning
5 participants