Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting #4502

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Fix formatting #4502

merged 5 commits into from
Dec 2, 2024

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Nov 29, 2024

... and with that making CI turn green again with some help of Tobias to get the lint results storage on the server fixed.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added the 2. developing Work in progress label Nov 29, 2024
@AndyScherzinger AndyScherzinger force-pushed the style/detekt branch 2 times, most recently from 162fb63 to 1849d05 Compare November 29, 2024 10:35
@mahibi mahibi self-requested a review November 29, 2024 11:38
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews technical debt Technical issue and removed 2. developing Work in progress labels Nov 29, 2024
@AndyScherzinger AndyScherzinger modified the milestones: 21.0.0, 20.1.0 Nov 29, 2024
@tobiasKaminsky
Copy link
Member

@AndyScherzinger lint is now "fixed", even though output is wrong.
On next PR after merging this, everything should be fine again.
If not, please ping me.

@AndyScherzinger
Copy link
Member Author

Thanks for your help @tobiasKaminsky 🙏

Feel. Free to merge @mahibi if fine with the PR

@mahibi mahibi enabled auto-merge December 2, 2024 09:41
Copy link
Contributor

github-actions bot commented Dec 2, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4502-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Codacy

Lint

TypemasterPR
Warnings94158
Errors13273

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

@mahibi mahibi merged commit fe8d89e into master Dec 2, 2024
17 checks passed
@mahibi mahibi deleted the style/detekt branch December 2, 2024 09:55
@mahibi
Copy link
Collaborator

mahibi commented Dec 2, 2024

Thank you Andy and Tobi!

@mahibi
Copy link
Collaborator

mahibi commented Dec 2, 2024

/backport to stable-20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews technical debt Technical issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants