Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a search bar to the "Join Open Conversations" screen #4471

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Added a search bar to the "Join Open Conversations" screen #4471

merged 3 commits into from
Nov 26, 2024

Conversation

rapterjet2004
Copy link
Contributor

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004
Should be working
6067f04 
Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004 rapterjet2004 requested a review from mahibi November 20, 2024 16:56
@mahibi
Copy link
Collaborator

mahibi commented Nov 21, 2024

search icon has wrong color
grafik

filter does not work for me / is very buggy. Search is done wrong or not at all..

grafik

grafik

@rapterjet2004
forgot to set ignoreCase to true
adea08c 
Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004
theme search icon
2bcdf05 
Signed-off-by: rapterjet2004 <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4471-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings94154
Errors13281

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7174
Internationalization33
Malicious code vulnerability33
Performance45
Security11
Total104108

Lint increased!

SpotBugs increased!

@mahibi mahibi merged commit 47004b8 into master Nov 26, 2024
15 of 18 checks passed
@mahibi mahibi deleted the issue-4452-search-join-conversation branch November 26, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search feature for "Join open conversations"
2 participants
@rapterjet2004 @mahibi