Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better call started indicator #4423

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Better call started indicator #4423

merged 1 commit into from
Nov 21, 2024

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Nov 6, 2024 •
edited
Loading

Screenshot 2024-11-08 at 10 13 20 AM

Screenshot 2024-11-08 at 10 13 27 AM

🚧 TODO

  • Setup View
  • Get Buttons working
  • Collapse animation
  • Remove old code
  • Fix avatars
  • Fix indicator not persisting in between lifecycle changes

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Nov 6, 2024
@rapterjet2004 rapterjet2004 self-assigned this Nov 6, 2024
@migulen
Copy link

migulen commented Nov 8, 2024 •
edited
Loading

@rapterjet2004 could be the QA has "stored" a not closed call from your server/configuration ?

Could it be your wish on your code of this QA ? I think it happen the first look to each room.

@rapterjet2004
Better Call Started Indicator
990f6ec 
- Pinned to MessageInputFragment
- Collapsable
- Looks cool

Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004 rapterjet2004 force-pushed the issue-4404-better-indicator-for-calls branch from 26dfddc to 990f6ec Compare November 11, 2024 14:34
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings94152
Errors13289

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7474
Internationalization33
Malicious code vulnerability33
Performance55
Security11
Total108108

Lint increased!

@rapterjet2004 rapterjet2004 marked this pull request as ready for review November 11, 2024 14:45
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4423-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi
Copy link
Collaborator

mahibi commented Nov 18, 2024

@rapterjet2004 could be the QA has "stored" a not closed call from your server/configuration ?

Could it be your wish on your code of this QA ? I think it happen the first look to each room.

i don't get this it yet. Could you show in a screenshot if anything is wrong?

@mahibi mahibi added this to the 20.1.0 milestone Nov 18, 2024
@migulen
Copy link

migulen commented Nov 19, 2024

@mahibi . Here it is.

20241119

It only happens on the QA, and I think Julius already change it.

@mahibi mahibi merged commit 90c6eb0 into master Nov 21, 2024
17 of 19 checks passed
@mahibi mahibi deleted the issue-4404-better-indicator-for-calls branch November 21, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
20.1.0
Development

Successfully merging this pull request may close these issues.

Better indicator whether a call is happening or not
3 participants
@rapterjet2004 @migulen @mahibi